Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update toml dependency to 0.8 #16

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Update toml dependency to 0.8 #16

merged 1 commit into from
Oct 31, 2023

Conversation

alex
Copy link
Contributor

@alex alex commented Oct 30, 2023

No description provided.

@adamreichold
Copy link
Member

Seeing this patch, I mainly wonder whether the full machinery of toml is appropriate or whether basic-toml would suffice?

@alex
Copy link
Contributor Author

alex commented Oct 30, 2023

I do not know the answer to that. I don't even remember what I was doing that led to this PR tbh, I got home from work and my terminal had this diff up. What was I doing this morning?

@messense messense merged commit f64fad6 into main Oct 31, 2023
5 checks passed
@messense messense deleted the alex-patch-1 branch October 31, 2023 11:26
@messense
Copy link
Member

For #10 we'd still depend on toml_edit, so IMO switching to basic-toml isn't helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alex @adamreichold @messense