Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix segfaults caused by modifying existing shared library #295

Merged
merged 5 commits into from
Oct 4, 2022
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions setuptools_rust/build.py
Original file line number Diff line number Diff line change
Expand Up @@ -345,6 +345,26 @@ def install_extension(
os.makedirs(os.path.dirname(ext_path), exist_ok=True)

log.info("Copying rust artifact from %s to %s", dylib_path, ext_path)

# We delete any existing library file before copying to avoid
# causing running processes that use it from segfaulting.
#
# This is because shared libraries are memory mapped into processes
# that use it, so modifying the shared library file (which is what
# `shutil.copyfile` does) means the next time a process calls into
# the shared library they get the updated library rather than the
# original one, causing confusion and segfaults.
#
# Deleting a memory mapped file, on the other hand, is correctly
# handled by the OS, i.e. a copy is kept around until the running
# process exits. Thus, deleting the existing library file and *then*
# copying the new one won't change the existing memory mapped file,
# and so is safe to do.
try:
os.remove(ext_path)
except FileNotFoundError:
pass

shutil.copyfile(dylib_path, ext_path)
adamreichold marked this conversation as resolved.
Show resolved Hide resolved

if sys.platform != "win32" and not debug_build:
Expand Down