Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Add support for space delimited multi-label targets #1076

Merged
merged 9 commits into from
Dec 15, 2021

Conversation

ethanwharris
Copy link
Collaborator

What does this PR do?

Fixes #836

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Dec 15, 2021

Codecov Report

Merging #1076 (0514d6d) into master (ba72af6) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1076      +/-   ##
==========================================
+ Coverage   87.61%   87.62%   +0.01%     
==========================================
  Files         281      281              
  Lines       12790    12804      +14     
==========================================
+ Hits        11206    11220      +14     
  Misses       1584     1584              
Flag Coverage Δ
unittests 87.62% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/image/detection/data.py 94.23% <ø> (ø)
flash/core/data/utilities/classification.py 98.75% <100.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba72af6...0514d6d. Read the comment docs.

@ethanwharris ethanwharris added the enhancement New feature or request label Dec 15, 2021
@ethanwharris ethanwharris merged commit 6f3dc08 into master Dec 15, 2021
@ethanwharris ethanwharris deleted the feature/space_delimited branch December 15, 2021 13:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError with Plant Pathology
1 participant