Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Fix val_split #1079

Merged
merged 3 commits into from
Dec 16, 2021
Merged

Fix val_split #1079

merged 3 commits into from
Dec 16, 2021

Conversation

ethanwharris
Copy link
Collaborator

@ethanwharris ethanwharris commented Dec 16, 2021

What does this PR do?

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Dec 16, 2021

Codecov Report

Merging #1079 (255d507) into master (f37e50d) will increase coverage by 0.10%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1079      +/-   ##
==========================================
+ Coverage   87.64%   87.75%   +0.10%     
==========================================
  Files         281      281              
  Lines       12793    12793              
==========================================
+ Hits        11212    11226      +14     
+ Misses       1581     1567      -14     
Flag Coverage Δ
unittests 87.75% <75.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/core/data/data_module.py 95.23% <75.00%> (+0.34%) ⬆️
flash/text/question_answering/model.py 91.15% <0.00%> (+0.68%) ⬆️
flash/core/integrations/icevision/adapter.py 93.15% <0.00%> (+9.58%) ⬆️
flash/core/data/splits.py 97.14% <0.00%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f37e50d...255d507. Read the comment docs.

@ethanwharris ethanwharris merged commit 4d00c34 into master Dec 16, 2021
@ethanwharris ethanwharris deleted the bugfix/val_split branch December 16, 2021 19:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants