Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Audio classification support for raw audio files #1085

Merged

Conversation

shivammehta25
Copy link
Contributor

@shivammehta25 shivammehta25 commented Dec 23, 2021

What does this PR do?

Fixes #526

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@shivammehta25 shivammehta25 changed the title Spectrogram audio loader [WIP] AudioClassificationFileInputToSpectrogram Dec 23, 2021
@codecov
Copy link

codecov bot commented Dec 23, 2021

Codecov Report

Merging #1085 (7cf8b2b) into master (3c74081) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1085   +/-   ##
=======================================
  Coverage   91.28%   91.29%           
=======================================
  Files         284      285    +1     
  Lines       12745    12759   +14     
=======================================
+ Hits        11634    11648   +14     
  Misses       1111     1111           
Flag Coverage Δ
unittests 91.29% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/audio/classification/data.py 100.00% <ø> (ø)
flash/audio/speech_recognition/data.py 100.00% <ø> (ø)
flash/audio/classification/input.py 97.80% <100.00%> (+0.33%) ⬆️
flash/audio/data.py 100.00% <100.00%> (ø)
flash/audio/speech_recognition/input.py 98.82% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c74081...7cf8b2b. Read the comment docs.

@ethanwharris ethanwharris added the enhancement New feature or request label Jan 5, 2022
Copy link
Collaborator

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a great start! Let's just add the support to the spectrogram_loader if possible 😃

flash/audio/classification/input.py Outdated Show resolved Hide resolved
flash/audio/classification/input.py Outdated Show resolved Hide resolved
@ethanwharris ethanwharris added this to the v0.8 milestone Feb 15, 2022
@krshrimali
Copy link
Contributor

Hi, @shivammehta007 - Hope all is well with you. Do you have any updates on this?

@shivammehta25
Copy link
Contributor Author

Hello, I am sorry have been busy on a project, I will be working with this over this weekend :)

@krshrimali
Copy link
Contributor

Hello, I am sorry have been busy on a project, I will be working with this over this weekend :)

Thanks, @shivammehta007 - no need to be sorry, I can understand! Please let us know if you need any help with this PR, happy to help. Please ping us whenever you are ready. 🚀

@ethanwharris ethanwharris marked this pull request as ready for review April 6, 2022 17:33
@ethanwharris ethanwharris changed the title [WIP] AudioClassificationFileInputToSpectrogram Audio classification support for raw audio files Apr 6, 2022
Copy link
Collaborator

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😃

@ethanwharris ethanwharris merged commit 2bee23d into Lightning-Universe:master Apr 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for loading of audio files and conversion to spectrograms
3 participants