Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Make Segmentation Tasks reproducible #1094

Conversation

bartonp2
Copy link
Contributor

@bartonp2 bartonp2 commented Jan 4, 2022

What does this PR do?

Previously, datasets created from a folder had a random order each time they were loaded. This commit fixes the order making results reproducible.

Not sure if this problem appears in any other tasks. Did a quick search for Folder Inputs of other tasks but did not find any that loaded data in a similar way.

Fixes #1060

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

Previously, datasets created from a folder had a random order each time they were loaded. This commit fixes the order making results reproducible
Copy link
Collaborator

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM 😃

@codecov
Copy link

codecov bot commented Jan 4, 2022

Codecov Report

Merging #1094 (efc26bc) into master (1a599ef) will decrease coverage by 9.31%.
The diff coverage is 100.00%.

❗ Current head efc26bc differs from pull request most recent head eece083. Consider uploading reports for the commit eece083 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1094      +/-   ##
==========================================
- Coverage   87.80%   78.49%   -9.32%     
==========================================
  Files         281      281              
  Lines       12793    12796       +3     
==========================================
- Hits        11233    10044    -1189     
- Misses       1560     2752    +1192     
Flag Coverage Δ
unittests 78.49% <100.00%> (-9.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/image/segmentation/input.py 83.16% <100.00%> (-12.76%) ⬇️
flash/text/question_answering/input.py 18.40% <0.00%> (-79.76%) ⬇️
flash/core/integrations/icevision/transforms.py 17.83% <0.00%> (-73.89%) ⬇️
...lash/image/embedding/vissl/transforms/multicrop.py 27.27% <0.00%> (-69.70%) ⬇️
...lash/image/embedding/vissl/transforms/utilities.py 14.63% <0.00%> (-68.30%) ⬇️
flash/image/detection/output.py 30.00% <0.00%> (-64.00%) ⬇️
flash/image/embedding/heads/vissl_heads.py 36.36% <0.00%> (-63.64%) ⬇️
flash/text/question_answering/model.py 28.57% <0.00%> (-62.59%) ⬇️
flash/image/detection/input.py 35.13% <0.00%> (-60.82%) ⬇️
flash/core/integrations/icevision/backbones.py 33.33% <0.00%> (-60.01%) ⬇️
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a599ef...eece083. Read the comment docs.

@ethanwharris ethanwharris merged commit 47b3dd6 into Lightning-Universe:master Jan 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug / fix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is there a way to seed experiments?
2 participants