Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Refactor Video Inputs #1117

Merged
merged 11 commits into from
Jan 17, 2022
Merged

Conversation

ethanwharris
Copy link
Collaborator

@ethanwharris ethanwharris commented Jan 14, 2022

What does this PR do?

  • Refactors video inputs to use the ClassificationInputMixin
  • Adds support for from_csv and from_data_frame to VideoClassificationData

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@mergify mergify bot removed the has conflicts label Jan 14, 2022
Base automatically changed from feature/refactor_classification_input to master January 14, 2022 14:18
@mergify mergify bot removed the has conflicts label Jan 14, 2022
@codecov
Copy link

codecov bot commented Jan 14, 2022

Codecov Report

Merging #1117 (8cb2fcc) into master (d01b5a0) will increase coverage by 0.02%.
The diff coverage is 89.06%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1117      +/-   ##
==========================================
+ Coverage   88.50%   88.53%   +0.02%     
==========================================
  Files         286      286              
  Lines       12937    12950      +13     
==========================================
+ Hits        11450    11465      +15     
+ Misses       1487     1485       -2     
Flag Coverage Δ
unittests 88.53% <89.06%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/video/classification/input.py 75.86% <84.44%> (+0.86%) ⬆️
flash/video/classification/data.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d01b5a0...8cb2fcc. Read the comment docs.

@ethanwharris ethanwharris changed the title Refactor video inputs to use the ClassificationInputMixin Refactor Video Inputs Jan 14, 2022
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks very clean 🤩

@ethanwharris ethanwharris merged commit 1bbd7d7 into master Jan 17, 2022
@ethanwharris ethanwharris deleted the feature/video_classification_targets branch January 17, 2022 11:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants