Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Docstrings for GraphClassificationData #1121

Merged
merged 7 commits into from
Jan 19, 2022
Merged

Docstrings for GraphClassificationData #1121

merged 7 commits into from
Jan 19, 2022

Conversation

ethanwharris
Copy link
Collaborator

What does this PR do?

Part of #957

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@ethanwharris ethanwharris added Data Pipeline V2 documentation Improvements or additions to documentation labels Jan 17, 2022
@codecov
Copy link

codecov bot commented Jan 17, 2022

Codecov Report

Merging #1121 (f124039) into master (68c3d70) will increase coverage by 9.59%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1121      +/-   ##
==========================================
+ Coverage   79.25%   88.84%   +9.59%     
==========================================
  Files         286      286              
  Lines       12917    12931      +14     
==========================================
+ Hits        10237    11489    +1252     
+ Misses       2680     1442    -1238     
Flag Coverage Δ
unittests 88.84% <100.00%> (+9.59%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/core/data/io/classification_input.py 100.00% <100.00%> (+7.40%) ⬆️
flash/core/data/utilities/classification.py 98.19% <100.00%> (+0.01%) ⬆️
flash/core/data/utilities/samples.py 100.00% <100.00%> (+7.14%) ⬆️
flash/graph/classification/data.py 100.00% <100.00%> (ø)
flash/graph/classification/input.py 100.00% <100.00%> (+7.69%) ⬆️
flash/graph/classification/input_transform.py 100.00% <100.00%> (ø)
flash/core/data/io/input_transform.py 73.86% <0.00%> (+0.47%) ⬆️
flash/image/classification/data.py 97.58% <0.00%> (+0.80%) ⬆️
flash/image/segmentation/model.py 92.50% <0.00%> (+1.25%) ⬆️
flash/image/classification/model.py 78.84% <0.00%> (+1.92%) ⬆️
... and 63 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68c3d70...f124039. Read the comment docs.

@ethanwharris ethanwharris mentioned this pull request Jan 17, 2022
9 tasks
flash/graph/classification/data.py Show resolved Hide resolved
@mergify mergify bot removed the has conflicts label Jan 19, 2022
@ethanwharris ethanwharris merged commit 4997226 into master Jan 19, 2022
@ethanwharris ethanwharris deleted the docs/graph_data branch January 19, 2022 13:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Data Pipeline V2 documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants