Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Docstrings for from_fiftyone #1136

Merged
merged 13 commits into from
Jan 26, 2022
Merged

Docstrings for from_fiftyone #1136

merged 13 commits into from
Jan 26, 2022

Conversation

ethanwharris
Copy link
Collaborator

@ethanwharris ethanwharris commented Jan 25, 2022

What does this PR do?

Part of #957

Fixes #1111

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@ethanwharris ethanwharris changed the title Doctest for ImageClassificationData.from_fiftyone Doctests for from_fiftyone Jan 25, 2022
@ethanwharris ethanwharris added bug / fix Something isn't working Data Pipeline V2 documentation Improvements or additions to documentation labels Jan 25, 2022
@ethanwharris ethanwharris mentioned this pull request Jan 25, 2022
9 tasks
@codecov
Copy link

codecov bot commented Jan 25, 2022

Codecov Report

Merging #1136 (be7214f) into master (fd1a2e4) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1136      +/-   ##
==========================================
+ Coverage   89.03%   89.07%   +0.04%     
==========================================
  Files         285      285              
  Lines       12980    13002      +22     
==========================================
+ Hits        11557    11582      +25     
+ Misses       1423     1420       -3     
Flag Coverage Δ
unittests 89.07% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/core/utilities/imports.py 92.81% <100.00%> (+0.17%) ⬆️
flash/image/classification/data.py 97.63% <100.00%> (+0.05%) ⬆️
flash/image/classification/input.py 100.00% <100.00%> (+1.20%) ⬆️
flash/image/detection/data.py 100.00% <100.00%> (ø)
flash/image/detection/input.py 100.00% <100.00%> (+2.73%) ⬆️
flash/image/segmentation/data.py 100.00% <100.00%> (ø)
flash/image/segmentation/input.py 100.00% <100.00%> (ø)
flash/video/classification/data.py 100.00% <100.00%> (ø)
flash/video/classification/input.py 95.65% <100.00%> (+0.24%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd1a2e4...be7214f. Read the comment docs.

@ethanwharris ethanwharris changed the title Doctests for from_fiftyone Docstrings for from_fiftyone Jan 25, 2022
@ethanwharris ethanwharris merged commit 76d6816 into master Jan 26, 2022
@ethanwharris ethanwharris deleted the docs/fiftyone_data branch January 26, 2022 13:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug / fix Something isn't working Data Pipeline V2 documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fiftyone dataset predictions not working
1 participant