Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Add support for from_files to ObjectDetectionData #1154

Merged
merged 5 commits into from
Feb 10, 2022

Conversation

ethanwharris
Copy link
Collaborator

@ethanwharris ethanwharris commented Feb 4, 2022

What does this PR do?

Fixes #1069

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Feb 4, 2022

Codecov Report

Merging #1154 (ea1e5cd) into master (450902d) will increase coverage by 0.01%.
The diff coverage is 90.16%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1154      +/-   ##
==========================================
+ Coverage   89.23%   89.24%   +0.01%     
==========================================
  Files         286      286              
  Lines       13022    13041      +19     
==========================================
+ Hits        11620    11639      +19     
  Misses       1402     1402              
Flag Coverage Δ
unittests 89.24% <90.16%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/core/integrations/icevision/transforms.py 93.24% <82.85%> (+0.04%) ⬆️
flash/core/data/io/classification_input.py 100.00% <100.00%> (ø)
flash/core/data/utilities/classification.py 98.22% <100.00%> (+0.03%) ⬆️
flash/image/detection/data.py 100.00% <100.00%> (ø)
flash/image/detection/input.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 450902d...ea1e5cd. Read the comment docs.

@ethanwharris ethanwharris added the enhancement New feature or request label Feb 7, 2022
@ethanwharris ethanwharris marked this pull request as ready for review February 7, 2022 15:50
@ethanwharris ethanwharris added this to the v0.7 milestone Feb 7, 2022
@ethanwharris ethanwharris merged commit 4b12e02 into master Feb 10, 2022
@ethanwharris ethanwharris deleted the feature/object_data_from_files branch February 10, 2022 14:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC] Better API for loading Object Detection data
1 participant