Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Expose normalization parameters #1178

Merged
merged 3 commits into from
Feb 19, 2022
Merged

Expose normalization parameters #1178

merged 3 commits into from
Feb 19, 2022

Conversation

AndresAlgaba
Copy link
Contributor

@AndresAlgaba AndresAlgaba commented Feb 17, 2022

What does this PR do?

This PR exposes the normalization parameters of torchvision.transforms.Normalize as transform_kwargs in the ImageClassificationInputTransform.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #1178 (f74f99e) into master (69dee81) will decrease coverage by 9.89%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1178      +/-   ##
==========================================
- Coverage   90.92%   81.03%   -9.90%     
==========================================
  Files         283      283              
  Lines       12699    12701       +2     
==========================================
- Hits        11547    10292    -1255     
- Misses       1152     2409    +1257     
Flag Coverage Δ
unittests 81.03% <100.00%> (-9.90%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/image/classification/input_transform.py 81.25% <100.00%> (-2.09%) ⬇️
flash/core/integrations/icevision/transforms.py 18.24% <0.00%> (-75.00%) ⬇️
...lash/image/embedding/vissl/transforms/multicrop.py 27.27% <0.00%> (-69.70%) ⬇️
flash/core/integrations/icevision/data.py 28.88% <0.00%> (-66.67%) ⬇️
flash/image/embedding/heads/vissl_heads.py 36.36% <0.00%> (-63.64%) ⬇️
flash/image/detection/input.py 36.66% <0.00%> (-63.34%) ⬇️
...ash/image/classification/integrations/baal/loop.py 32.08% <0.00%> (-62.69%) ⬇️
flash/core/integrations/icevision/backbones.py 33.33% <0.00%> (-60.01%) ⬇️
...ash/image/classification/integrations/baal/data.py 34.34% <0.00%> (-59.60%) ⬇️
...age/face_detection/backbones/fastface_backbones.py 42.10% <0.00%> (-57.90%) ⬇️
... and 66 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69dee81...f74f99e. Read the comment docs.

Copy link
Collaborator

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM 😃

@ethanwharris ethanwharris added the enhancement New feature or request label Feb 18, 2022
@ethanwharris ethanwharris added this to the v0.8 milestone Feb 18, 2022
@ethanwharris ethanwharris merged commit dbbc7c4 into Lightning-Universe:master Feb 19, 2022
@ethanwharris ethanwharris modified the milestones: 0.8.0, 0.7.x Mar 1, 2022
ethanwharris added a commit that referenced this pull request Mar 1, 2022
Co-authored-by: Ethan Harris <ethanwharris@gmail.com>
ethanwharris added a commit that referenced this pull request Mar 1, 2022
Co-authored-by: Ethan Harris <ethanwharris@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants