-
Notifications
You must be signed in to change notification settings - Fork 212
Fix normalizing video classification input #1213
Fix normalizing video classification input #1213
Conversation
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #1213 +/- ##
=======================================
Coverage 90.96% 90.96%
=======================================
Files 284 284
Lines 12694 12696 +2
=======================================
+ Hits 11547 11549 +2
Misses 1147 1147
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!!! LGTM 😃 Just a small suggestion. @dudeperf3ct Could you also add a Fixed
entry to the CHANGELOG?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! LGTM 😃
Co-authored-by: Ethan Harris <ethanwharris@gmail.com>
Co-authored-by: Ethan Harris <ethanwharris@gmail.com>
What does this PR do?
Fixes #1193
Additional comment: Added a new lambda temporary function to avoid pickling error while training on multiple gpus as proposed in facebookresearch/pytorchvideo#101
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃