This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 212
Propagate collate_fn
to InputTransform
in ImageEmbedder
#1217
Merged
ethanwharris
merged 13 commits into
master
from
fix/ImageEmbedder/InputTransform/collate-fn
Mar 28, 2022
Merged
Propagate collate_fn
to InputTransform
in ImageEmbedder
#1217
ethanwharris
merged 13 commits into
master
from
fix/ImageEmbedder/InputTransform/collate-fn
Mar 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krshrimali
requested review from
ethanwharris,
Borda,
tchaton,
ananyahjha93,
justusschock,
carmocca and
kaushikb11
as code owners
March 5, 2022 03:03
for more information, see https://pre-commit.ci
…com:PyTorchLightning/lightning-flash into fix/ImageEmbedder/InputTransform/collate-fn
krshrimali
commented
Mar 5, 2022
Codecov Report
@@ Coverage Diff @@
## master #1217 +/- ##
==========================================
+ Coverage 91.06% 91.18% +0.11%
==========================================
Files 286 286
Lines 12764 12790 +26
==========================================
+ Hits 11623 11662 +39
+ Misses 1141 1128 -13
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ethanwharris
approved these changes
Mar 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, LGTM 😃
ethanwharris
added a commit
that referenced
this pull request
Mar 30, 2022
Co-authored-by: Ethan Harris <ethanwharris@gmail.com>
ethanwharris
added a commit
that referenced
this pull request
Mar 30, 2022
Co-authored-by: Ethan Harris <ethanwharris@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Looks like
collate_fn
was never propagated before. The reason it worked before:pretraining_transform
was never called, hence the inputs were always tensors and not a list of tensors (so no need to collate).Fixes #1218.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃