Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Fix detection ddp spawn #1222

Merged
merged 40 commits into from
Mar 22, 2022
Merged

Fix detection ddp spawn #1222

merged 40 commits into from
Mar 22, 2022

Conversation

ethanwharris
Copy link
Collaborator

@ethanwharris ethanwharris commented Mar 7, 2022

What does this PR do?

Fixes #1219

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Mar 7, 2022

Codecov Report

Merging #1222 (062cd15) into master (e943921) will decrease coverage by 0.02%.
The diff coverage is 67.44%.

@@            Coverage Diff             @@
##           master    #1222      +/-   ##
==========================================
- Coverage   91.11%   91.09%   -0.03%     
==========================================
  Files         284      284              
  Lines       12754    12768      +14     
==========================================
+ Hits        11621    11631      +10     
- Misses       1133     1137       +4     
Flag Coverage Δ
unittests 91.09% <67.44%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/image/detection/backbones.py 74.41% <18.18%> (-3.09%) ⬇️
flash/core/integrations/icevision/transforms.py 91.44% <69.23%> (-1.80%) ⬇️
flash/core/integrations/icevision/adapter.py 93.24% <83.33%> (+0.09%) ⬆️
flash/core/integrations/icevision/backbones.py 94.44% <100.00%> (+1.11%) ⬆️
flash/text/question_answering/model.py 92.56% <0.00%> (+0.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e943921...062cd15. Read the comment docs.

@ethanwharris ethanwharris added the bug / fix Something isn't working label Mar 7, 2022
@ethanwharris ethanwharris changed the title [WIP] Fix detection ddp spawn Fix detection ddp spawn Mar 22, 2022
@ethanwharris ethanwharris merged commit fa8ccbc into master Mar 22, 2022
@ethanwharris ethanwharris deleted the bugfix/detection_ddp_spawn branch March 22, 2022 22:12
ethanwharris added a commit that referenced this pull request Mar 30, 2022
ethanwharris added a commit that referenced this pull request Mar 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug / fix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DDP Spawn for object detection
2 participants