Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Fix HF LR schedulers #1307

Merged
merged 17 commits into from
Apr 27, 2022
Merged

Fix HF LR schedulers #1307

merged 17 commits into from
Apr 27, 2022

Conversation

ethanwharris
Copy link
Collaborator

What does this PR do?

Fixes #1304

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@ethanwharris ethanwharris added the bug / fix Something isn't working label Apr 25, 2022
@ethanwharris ethanwharris added this to the 0.7.x milestone Apr 25, 2022
@codecov
Copy link

codecov bot commented Apr 25, 2022

Codecov Report

Merging #1307 (d3ba338) into master (bd62406) will decrease coverage by 0.09%.
The diff coverage is 77.41%.

@@            Coverage Diff             @@
##           master    #1307      +/-   ##
==========================================
- Coverage   91.75%   91.66%   -0.10%     
==========================================
  Files         287      287              
  Lines       12816    12833      +17     
==========================================
+ Hits        11759    11763       +4     
- Misses       1057     1070      +13     
Flag Coverage Δ
unittests 91.66% <77.41%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/text/classification/data.py 100.00% <ø> (ø)
flash/core/model.py 88.80% <50.00%> (+0.43%) ⬆️
flash/core/trainer.py 89.74% <81.48%> (-2.48%) ⬇️
flash/core/serve/interfaces/models.py 95.58% <0.00%> (-4.42%) ⬇️
flash/core/serve/interfaces/http.py 93.67% <0.00%> (-3.80%) ⬇️
flash/core/data/utils.py 89.18% <0.00%> (-1.36%) ⬇️
flash/pointcloud/segmentation/model.py 79.76% <0.00%> (-1.20%) ⬇️
flash/core/utilities/imports.py 91.71% <0.00%> (-1.19%) ⬇️
flash/image/segmentation/model.py 91.76% <0.00%> (-1.18%) ⬇️
flash/core/data/io/input.py 96.03% <0.00%> (-0.80%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd62406...d3ba338. Read the comment docs.

@ethanwharris ethanwharris marked this pull request as ready for review April 26, 2022 11:29
@ethanwharris ethanwharris merged commit 9888c9c into master Apr 27, 2022
@ethanwharris ethanwharris deleted the bugfix/hf_lr_schedulers branch April 27, 2022 10:06
krshrimali pushed a commit that referenced this pull request Apr 27, 2022
ethanwharris added a commit that referenced this pull request Apr 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug / fix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi-label example breaks when adding lr_scheduler
3 participants