Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Fix tabular classifier serve #1324

Merged
merged 5 commits into from
May 3, 2022
Merged

Conversation

ethanwharris
Copy link
Collaborator

@ethanwharris ethanwharris commented May 3, 2022

What does this PR do?

Fixes flash serve with the tabular classifier checkpoint

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@ethanwharris ethanwharris added the bug / fix Something isn't working label May 3, 2022
@ethanwharris ethanwharris added this to the 0.7.x milestone May 3, 2022
@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #1324 (5144afd) into master (7facf06) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1324   +/-   ##
=======================================
  Coverage   91.66%   91.66%           
=======================================
  Files         287      287           
  Lines       12833    12843   +10     
=======================================
+ Hits        11763    11773   +10     
  Misses       1070     1070           
Flag Coverage Δ
unittests 91.66% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/tabular/classification/model.py 97.36% <100.00%> (+0.39%) ⬆️
flash/tabular/regression/model.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7facf06...5144afd. Read the comment docs.

@ethanwharris ethanwharris merged commit d5c5069 into master May 3, 2022
@ethanwharris ethanwharris deleted the bugfix/tabular_parameters branch May 3, 2022 12:21
ethanwharris added a commit that referenced this pull request May 11, 2022
ethanwharris added a commit that referenced this pull request May 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug / fix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant