-
Notifications
You must be signed in to change notification settings - Fork 212
Conversation
Codecov Report
@@ Coverage Diff @@
## master #133 +/- ##
=======================================
Coverage 87.04% 87.04%
=======================================
Files 49 49
Lines 1590 1590
=======================================
Hits 1384 1384
Misses 206 206
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
@carmocca @kaushikb11 can we continue the |
@kaushikb11 any progress here? it would be nice to have Flash release working fine with mainstream PL (not the hack RC we have now) cc: @aribornstein |
@Borda Let me look at the failing tests today, weren't failing before. |
Also #130. And updating the Lightning Trainer to call |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IDK about the finetunning functions but the change of requirements is needed to unbock other branches like datapipeline. If not inconvenient I'd merge. /cc @kaushikb11 @tchaton
@kaushikb11 there are some PL related error, such as misconfiguration, mind have a look |
@Borda Sure! |
One Unblocking PR Lightning-AI/pytorch-lightning#6541 |
which means we would need to sen min version to 1.2.4 or higher... |
What does this PR do?
Fixes #132
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃