-
Notifications
You must be signed in to change notification settings - Fork 212
add instance segmentation per_sample_transform #1353
add instance segmentation per_sample_transform #1353
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1353 +/- ##
==========================================
- Coverage 92.68% 91.57% -1.12%
==========================================
Files 286 286
Lines 12802 12814 +12
==========================================
- Hits 11866 11734 -132
- Misses 936 1080 +144
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
for more information, see https://pre-commit.ci
Co-authored-by: Ethan Harris <ethanwharris@gmail.com>
…nsform' into instance_segmentation_resize_transform
@ethanwharris Hi, may I ask for help? ) Could you approve a workflow for test running? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MrShevan This looks awesome! Don't worry about the tests, I think something is going wrong unrelated to your PR 😃
@ethanwharris Thanks for reviewing ! :) Yeah, errors look like not corresponding on PR. Is there anything else I need to do to merge? Or just waiting? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @MrShevan for the PR! LGTM.
@MrShevan - I guess we can merge this :) I'm going to merge this for now, once all tests are done. Thank you for your contribution. |
@ethanwharris @krshrimali Thanks for your review ! It was a pleasure for me to work on this PR :) |
What does this PR do?
Fixes #930
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?