Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

add instance segmentation per_sample_transform #1353

Conversation

MrShevan
Copy link
Contributor

@MrShevan MrShevan commented May 27, 2022

What does this PR do?

Fixes #930

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

  • Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented May 27, 2022

Codecov Report

Merging #1353 (2694869) into master (0001838) will decrease coverage by 1.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1353      +/-   ##
==========================================
- Coverage   92.68%   91.57%   -1.12%     
==========================================
  Files         286      286              
  Lines       12802    12814      +12     
==========================================
- Hits        11866    11734     -132     
- Misses        936     1080     +144     
Flag Coverage Δ
unittests 91.57% <100.00%> (-1.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/core/integrations/icevision/transforms.py 92.07% <100.00%> (+0.40%) ⬆️
flash/image/detection/output.py 95.65% <100.00%> (ø)
flash/image/instance_segmentation/data.py 100.00% <100.00%> (ø)
flash/audio/classification/input.py 42.85% <0.00%> (-54.95%) ⬇️
flash/audio/classification/data.py 50.00% <0.00%> (-50.00%) ⬇️
flash/audio/speech_recognition/cli.py 60.00% <0.00%> (-40.00%) ⬇️
flash/audio/classification/cli.py 63.63% <0.00%> (-36.37%) ⬇️
flash/audio/speech_recognition/input.py 63.52% <0.00%> (-35.30%) ⬇️
flash/audio/classification/input_transform.py 65.38% <0.00%> (-26.93%) ⬇️
flash/audio/speech_recognition/data.py 80.00% <0.00%> (-20.00%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0001838...2694869. Read the comment docs.

@MrShevan MrShevan marked this pull request as ready for review May 27, 2022 19:47
@MrShevan
Copy link
Contributor Author

@ethanwharris Hi, may I ask for help? )
I created all necessary tests for my new code changes. But It's strange that Codecov reports: will decrease coverage by 19.69%.

Could you approve a workflow for test running?

Copy link
Collaborator

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MrShevan This looks awesome! Don't worry about the tests, I think something is going wrong unrelated to your PR 😃

@ethanwharris ethanwharris added the enhancement New feature or request label Jun 17, 2022
@ethanwharris ethanwharris added this to the 0.8.0 milestone Jun 17, 2022
@MrShevan
Copy link
Contributor Author

@ethanwharris Thanks for reviewing ! :)

Yeah, errors look like not corresponding on PR. Is there anything else I need to do to merge? Or just waiting?

Copy link
Contributor

@krshrimali krshrimali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @MrShevan for the PR! LGTM.

@krshrimali
Copy link
Contributor

@MrShevan - I guess we can merge this :) I'm going to merge this for now, once all tests are done. Thank you for your contribution.

@krshrimali krshrimali enabled auto-merge (squash) June 20, 2022 11:01
@ethanwharris ethanwharris merged commit 0ae31c8 into Lightning-Universe:master Jun 28, 2022
@MrShevan
Copy link
Contributor Author

@ethanwharris @krshrimali Thanks for your review ! It was a pleasure for me to work on this PR :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

resize instance segmentation mask
5 participants