Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

fix SpeechRecognitionOutputTransform if local #1362

Merged
merged 8 commits into from
Jun 29, 2022
Merged

fix SpeechRecognitionOutputTransform if local #1362

merged 8 commits into from
Jun 29, 2022

Conversation

flozi00
Copy link
Contributor

@flozi00 flozi00 commented Jun 12, 2022

What does this PR do?

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jun 12, 2022

Codecov Report

Merging #1362 (0438dad) into master (345c95c) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1362      +/-   ##
==========================================
- Coverage   92.71%   92.69%   -0.02%     
==========================================
  Files         286      286              
  Lines       12814    12814              
==========================================
- Hits        11880    11878       -2     
- Misses        934      936       +2     
Flag Coverage Δ
unittests 92.69% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/audio/speech_recognition/model.py 100.00% <ø> (ø)
flash/text/question_answering/collate.py 95.29% <0.00%> (-2.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 345c95c...0438dad. Read the comment docs.

Copy link
Collaborator

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, LGTM 😃

@ethanwharris ethanwharris added the bug / fix Something isn't working label Jun 17, 2022
@ethanwharris ethanwharris added this to the 0.7.x milestone Jun 17, 2022
Copy link
Contributor

@krshrimali krshrimali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @flozi00 for the PR. LGTM, would you also like adding a brief description of this arg processor_backbone to the docstring of SpeechRecognition class? Here: https://github.com/Lightning-AI/lightning-flash/blob/ba7cb1c3bb7c52197f2cb3aedc36981d00df9e4e/flash/audio/speech_recognition/model.py#L42

If you decide to make another PR for that, that also works. But let's not block this PR for the change, I'll merge this now. 🎉 Thank you for your contribution.

@krshrimali krshrimali enabled auto-merge (squash) June 21, 2022 03:48
@ethanwharris ethanwharris modified the milestones: 0.7.x, 0.8.0 Jun 29, 2022
@ethanwharris ethanwharris merged commit ee512a2 into Lightning-Universe:master Jun 29, 2022
@flozi00 flozi00 deleted the patch-1 branch June 29, 2022 19:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug / fix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants