-
Notifications
You must be signed in to change notification settings - Fork 212
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1387 +/- ##
==========================================
+ Coverage 92.82% 92.92% +0.10%
==========================================
Files 285 285
Lines 12763 12778 +15
==========================================
+ Hits 11847 11874 +27
+ Misses 916 904 -12
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @ethanwharris - wow! This looks great. 🎉 🔥 🚀 Thanks for the summary in the description as well. Sorry for the late comments, I don't really have any suggestions but a couple of questions:
- Since URLs are supported, apart from the release notes, we need a way to tell the users that they can pass the URLs instead of downloading the CSV files using
download_data
. What are your opinions on raising aUserWarning
or a message for calls todownload_data
? Something like:
UserWarning: For Lightning Flash v0.8.0+, URLs are now supported to be passed directly. If your use-case supports it, you can now skip the call to `download_data`, and directly pass the URL to your file.
- Curious to know what went wrong with the MP3 files? If you have any info on it, we can probably create an issue and come back to it later.
In a separate PR though, we can also update the examples to skip downloading data, whenever possible, and pass the URLs directly. (this can be an issue for the community to come in ⚡)
@krshrimali Thanks for the comments! Here are my thoughts 😃
|
What does this PR do?
Refactors file loading to use fsspec and a series of other enhancements:
Fixes #1298
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃