This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 212
Fix CI and attempt to improve flaky tests #1394
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krshrimali
requested review from
ethanwharris,
Borda,
tchaton,
justusschock and
kaushikb11
as code owners
July 15, 2022 07:51
Codecov Report
@@ Coverage Diff @@
## master #1394 +/- ##
=======================================
Coverage 92.91% 92.91%
=======================================
Files 285 286 +1
Lines 12778 12835 +57
=======================================
+ Hits 11873 11926 +53
- Misses 905 909 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
krshrimali
commented
Jul 15, 2022
krshrimali
commented
Jul 15, 2022
krshrimali
commented
Jul 18, 2022
krshrimali
changed the title
Attempt to fix CI
Fix CI and attempt to improve flaky tests
Jul 18, 2022
Once and if all the tests pass, I'll update the CHANGELOG. I don't want to trigger the CI again when it's not worth it. :) |
ethanwharris
approved these changes
Jul 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! LGTM 😃
…ning/lightning-flash into ci/fix_examples_third_party
krshrimali
commented
Jul 18, 2022
krshrimali
commented
Jul 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR was an attempt to fix the CI, and it turned out to be successful. :) Here is the summary of what's done:
style_transfer.py
script, the dataset we download contains an image with one number of channels (data/coco128/images/train2017/000000000086.jpg
) - and pystiche raised an error while trying to normalize. It looks like the image wasn't converted to RGB through our loader, and that is fixed in this PR.test_speed
seems to be flaky for Windows/Mac, and we are trying to be softer in this PR. Let's investigate again if they appear to be flaky in the future.Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃