This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Add download support for tar.gz & don't download data if exists #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaushikb11
requested review from
Borda,
carmocca,
justusschock,
tchaton and
teddykoker
as code owners
Codecov Report
@@ Coverage Diff @@
## master #157 +/- ##
==========================================
+ Coverage 78.39% 87.03% +8.64%
==========================================
Files 49 49
Lines 1583 1589 +6
==========================================
+ Hits 1241 1383 +142
+ Misses 342 206 -136
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Borda
approved these changes
Mar 5, 2021
teddykoker
approved these changes
Mar 6, 2021
carmocca
reviewed
Mar 6, 2021
carmocca
reviewed
Mar 6, 2021
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
justusschock
approved these changes
Mar 10, 2021
|
What's blocking this from being merged? |
|
Hello @kaushikb11! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-03-22 18:51:30 UTC |
kaushikb11
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix: Don't download data if exists. Will throw an error if Data exists in the working directory, and there's no internet.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃