This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Catch URLError #237
Merged
Catch URLError #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanwharris
requested review from
Borda,
carmocca,
justusschock,
kaushikb11 and
tchaton
as code owners
Codecov Report
@@ Coverage Diff @@
## master #237 +/- ##
==========================================
+ Coverage 86.90% 86.95% +0.05%
==========================================
Files 58 58
Lines 3055 3067 +12
==========================================
+ Hits 2655 2667 +12
Misses 400 400
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
edgarriba
approved these changes
Apr 22, 2021
kaushikb11
reviewed
Apr 22, 2021
carmocca
approved these changes
Apr 22, 2021
flash/vision/backbones.py
Outdated
Comment on lines
62
to
67
| result = fn(*args, pretrained=False, **kwargs) | ||
| rank_zero_warn( | ||
| "Failed to download pretrained weights for the selected backbone. The backbone has been created with" | ||
| " `pretrained=False` instead. If you are loading from a local checkpoint, this warning can be safely" | ||
| " ignored.", UserWarning | ||
| ) |
There was a problem hiding this comment.
Changed the order so if the fn call fails too, the warning is still shown
Suggested change
| result = fn(*args, pretrained=False, **kwargs) | |
| rank_zero_warn( | |
| "Failed to download pretrained weights for the selected backbone. The backbone has been created with" | |
| " `pretrained=False` instead. If you are loading from a local checkpoint, this warning can be safely" | |
| " ignored.", UserWarning | |
| ) | |
| rank_zero_warn( | |
| "Failed to download pretrained weights for the selected backbone. The backbone has been created with" | |
| " `pretrained=False` instead. If you are loading from a local checkpoint, this warning can be safely" | |
| " ignored.", UserWarning | |
| ) | |
| result = fn(*args, pretrained=False, **kwargs) |
There was a problem hiding this comment.
Not sure we want this. If it fails with pretrained=False then the warning is no longer true when it says "the backbone has been created"?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #155
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃