This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Add semantic segmentation task #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #239 +/- ##
==========================================
- Coverage 88.32% 88.26% -0.06%
==========================================
Files 68 74 +6
Lines 3288 3563 +275
==========================================
+ Hits 2904 3145 +241
- Misses 384 418 +34
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Hello @edgarriba! Thanks for updating this PR.
Comment last updated at 2021-05-10 14:14:49 UTC |
flash/vision/segmentation/model.py
Outdated
Comment on lines
81
to
118
| @SemanticSegmentation.backbones(name="torchvision/fcn_resnet50") | ||
| def fn(pretrained: bool, num_classes: int): | ||
| import torchvision | ||
| model: nn.Module = torchvision.models.segmentation.fcn_resnet50(pretrained=pretrained, num_classes=num_classes) | ||
| return model |
There was a problem hiding this comment.
maybe only register this if torchvision is installed?
flash/vision/segmentation/data.py
Outdated
| @@ -18,38 +31,14 @@ | |||
| from flash.data.process import Preprocess | |||
| from flash.utils.imports import _KORNIA_AVAILABLE, _MATPLOTLIB_AVAILABLE | |||
|
|
|||
| from . import transforms as T | |||
There was a problem hiding this comment.
Can we stay consistent with avoiding relative imports here?
edgarriba
force-pushed
the
feat/segmentation
branch
from
341595e
to
7343887
Compare
ethanwharris
changed the title
ethanwharris
changed the title
tchaton
reviewed
May 10, 2021
Co-authored-by: thomas chaton <thomas@grid.ai>
Co-authored-by: thomas chaton <thomas@grid.ai>
edgarriba
commented
May 10, 2021
| test_transform=test_transform, | ||
| predict_transform=predict_transform, | ||
| data_sources={DefaultDataSources.PATHS: SemanticSegmentationPathsDataSource()}, | ||
| default_data_source=DefaultDataSources.PATHS, |
There was a problem hiding this comment.
@ethanwharris cannot this be overwritten by data_sources key ?
tchaton
reviewed
May 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR implements semantic segmentation task. It includes the following data structures:
SemantincSegmentationPreprocessSemantincSegmentationDataSemantincSegmentationsome results:
TODO:
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃