Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

[feat] Add Dino #259

Merged
merged 2 commits into from
May 2, 2021
Merged

[feat] Add Dino #259

merged 2 commits into from
May 2, 2021

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented May 2, 2021

What does this PR do?

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented May 2, 2021

Codecov Report

Merging #259 (941911a) into master (8007c26) will decrease coverage by 0.22%.
The diff coverage is 70.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #259      +/-   ##
==========================================
- Coverage   87.37%   87.14%   -0.23%     
==========================================
  Files          62       62              
  Lines        3294     3313      +19     
==========================================
+ Hits         2878     2887       +9     
- Misses        416      426      +10     
Flag Coverage Δ
unittests 87.14% <70.00%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/vision/backbones.py 79.61% <64.70%> (-2.95%) ⬇️
flash/vision/classification/model.py 96.29% <100.00%> (+0.29%) ⬆️
flash/video/classification/data.py 73.03% <0.00%> (-4.50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8007c26...941911a. Read the comment docs.

@tchaton tchaton merged commit 8bf5d76 into master May 2, 2021
@tchaton tchaton deleted the dino branch May 2, 2021 16:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant