Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

change resize interpolation default mode to nearest #352

Closed
wants to merge 2 commits into from

Conversation

edgarriba
Copy link
Contributor

@edgarriba edgarriba commented Jun 1, 2021

What does this PR do?

use nearest interpolation method in resize by default to avoid artifacts in the data

nearest

image

blinear

image

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jun 1, 2021

Codecov Report

Merging #352 (7edac33) into master (2da2328) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #352   +/-   ##
=======================================
  Coverage   88.82%   88.82%           
=======================================
  Files          80       80           
  Lines        4143     4143           
=======================================
  Hits         3680     3680           
  Misses        463      463           
Flag Coverage Δ
unittests 88.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/image/segmentation/transforms.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2da2328...7edac33. Read the comment docs.

@ethanwharris
Copy link
Collaborator

Covered by #351

@Borda Borda deleted the edgarriba-patch-1 branch April 27, 2022 14:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants