Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Added **kwargs #377

Merged
merged 2 commits into from
Jun 8, 2021
Merged

Added **kwargs #377

merged 2 commits into from
Jun 8, 2021

Conversation

aribornstein
Copy link
Contributor

@aribornstein aribornstein commented Jun 8, 2021

Fixed keywords for timm for vision transformer models

Fixes #376

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

Fixed keywords for timm for vision transformer models
@codecov
Copy link

codecov bot commented Jun 8, 2021

Codecov Report

Merging #377 (5b6aeb0) into master (4b6d2ec) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #377   +/-   ##
=======================================
  Coverage   89.44%   89.44%           
=======================================
  Files          80       80           
  Lines        4180     4180           
=======================================
  Hits         3739     3739           
  Misses        441      441           
Flag Coverage Δ
unittests 89.44% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/image/backbones.py 86.40% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b6d2ec...5b6aeb0. Read the comment docs.

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: __init__() got an unexpected keyword argument 'global_pool'
2 participants