Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Fix metadata dict support #393

Merged
merged 4 commits into from
Jun 11, 2021
Merged

Fix metadata dict support #393

merged 4 commits into from
Jun 11, 2021

Conversation

ethanwharris
Copy link
Collaborator

What does this PR do?

Fixes #384

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jun 10, 2021

Codecov Report

Merging #393 (f0d5725) into master (c720807) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #393      +/-   ##
==========================================
+ Coverage   89.80%   89.82%   +0.02%     
==========================================
  Files          80       80              
  Lines        4207     4217      +10     
==========================================
+ Hits         3778     3788      +10     
  Misses        429      429              
Flag Coverage Δ
gpu ?
pytest ?
unittests 89.82% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/core/data/batch.py 96.89% <100.00%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c720807...f0d5725. Read the comment docs.

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@ethanwharris ethanwharris merged commit 7992684 into master Jun 11, 2021
@ethanwharris ethanwharris deleted the bugfix/metadata branch June 11, 2021 08:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

METADATA can't be a dict
3 participants