Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Fixes predict batches should now be shown for image class… #438

Merged
merged 5 commits into from
Jun 21, 2021

Conversation

fstroth
Copy link
Contributor

@fstroth fstroth commented Jun 21, 2021

predict batches should now be shown for image classification.

Fixes #430

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@pep8speaks
Copy link

pep8speaks commented Jun 21, 2021

Hello @fstroth! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-06-21 19:30:17 UTC

@codecov
Copy link

codecov bot commented Jun 21, 2021

Codecov Report

Merging #438 (d92090d) into master (40fc879) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #438   +/-   ##
=======================================
  Coverage   91.57%   91.57%           
=======================================
  Files         112      112           
  Lines        7063     7063           
=======================================
  Hits         6468     6468           
  Misses        595      595           
Flag Coverage Δ
unittests 91.57% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/image/classification/data.py 95.29% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40fc879...d92090d. Read the comment docs.

@Borda Borda changed the title (FIX) Fixes #430, predict batches should now be shown for image class… Fixes predict batches should now be shown for image class… Jun 21, 2021
Copy link
Collaborator

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ethanwharris ethanwharris added this to the 0.4 milestone Jun 21, 2021
@ethanwharris ethanwharris merged commit 7111e82 into Lightning-Universe:master Jun 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

show_predict_batch fails due to no targets being available
3 participants