Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Fix serve sanity checking #493

Merged
merged 2 commits into from
Jun 29, 2021
Merged

Fix serve sanity checking #493

merged 2 commits into from
Jun 29, 2021

Conversation

ethanwharris
Copy link
Collaborator

@ethanwharris ethanwharris commented Jun 29, 2021

What does this PR do?

Fixes #492

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@codecov
Copy link

codecov bot commented Jun 29, 2021

Codecov Report

Merging #493 (fba0aea) into master (da5b5a8) will decrease coverage by 0.03%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #493      +/-   ##
==========================================
- Coverage   91.46%   91.42%   -0.04%     
==========================================
  Files         112      112              
  Lines        7098     7103       +5     
==========================================
+ Hits         6492     6494       +2     
- Misses        606      609       +3     
Flag Coverage Δ
unittests 91.42% <50.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/core/trainer.py 84.61% <50.00%> (-2.60%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da5b5a8...fba0aea. Read the comment docs.

@ethanwharris ethanwharris merged commit 7b584d6 into master Jun 29, 2021
@ethanwharris ethanwharris deleted the bugfix/sanity_check branch June 29, 2021 12:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Serve sanity check never called with PL master
2 participants