Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Image classification csv data source #556

Merged
merged 8 commits into from
Jul 10, 2021

Conversation

ethanwharris
Copy link
Collaborator

What does this PR do?

Fixes #257

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jul 8, 2021

Codecov Report

Merging #556 (6ce1679) into master (fb51cc4) will increase coverage by 0.02%.
The diff coverage is 94.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #556      +/-   ##
==========================================
+ Coverage   91.31%   91.33%   +0.02%     
==========================================
  Files         112      112              
  Lines        7128     7193      +65     
==========================================
+ Hits         6509     6570      +61     
- Misses        619      623       +4     
Flag Coverage Δ
unittests 91.33% <94.11%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/image/classification/model.py 86.66% <ø> (ø)
flash/image/classification/data.py 94.66% <94.11%> (-0.63%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb51cc4...6ce1679. Read the comment docs.

@ethanwharris
Copy link
Collaborator Author

@aniketmaurya Mind reviewing this? I can't request a review from people outside PL org I think

Copy link
Contributor

@aniketmaurya aniketmaurya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for adding this feature @ethanwharris 🚀

@ethanwharris ethanwharris merged commit ddd85f0 into master Jul 10, 2021
@ethanwharris ethanwharris deleted the feature/image_csv_data_source branch July 10, 2021 11:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

from_csv or from_df method in ImageClassificationData
3 participants