Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

[Feat] Add PointCloud Segmentation #566

Merged
merged 25 commits into from
Jul 14, 2021
Merged

[Feat] Add PointCloud Segmentation #566

merged 25 commits into from
Jul 14, 2021

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Jul 12, 2021

What does this PR do?

This PR adds a PointCloudSegmentation task

Screenshot 2021-07-14 at 13 08 03

pointcloud_predictions

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jul 12, 2021

Codecov Report

Merging #566 (803ab59) into master (a340464) will decrease coverage by 1.07%.
The diff coverage is 73.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #566      +/-   ##
==========================================
- Coverage   91.71%   90.63%   -1.08%     
==========================================
  Files         122      132      +10     
  Lines        7327     7766     +439     
==========================================
+ Hits         6720     7039     +319     
- Misses        607      727     +120     
Flag Coverage Δ
unittests 90.63% <73.19%> (-1.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/pointcloud/segmentation/open3d_ml/app.py 32.00% <32.00%> (ø)
flash/pointcloud/segmentation/datasets.py 50.00% <50.00%> (ø)
...ash/pointcloud/segmentation/open3d_ml/backbones.py 61.70% <61.70%> (ø)
flash/pointcloud/segmentation/model.py 76.66% <76.66%> (ø)
flash/pointcloud/segmentation/data.py 80.00% <80.00%> (ø)
...tcloud/segmentation/open3d_ml/sequences_dataset.py 82.56% <82.56%> (ø)
flash/core/model.py 86.25% <83.78%> (-0.28%) ⬇️
flash/core/data/batch.py 95.85% <100.00%> (-0.58%) ⬇️
flash/core/data/data_module.py 94.35% <100.00%> (+0.41%) ⬆️
flash/core/data/process.py 86.58% <100.00%> (+0.23%) ⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a340464...803ab59. Read the comment docs.

@tchaton tchaton changed the title [Feat] Add PointCloud Classification [Feat] Add PointCloud Segmentation Jul 12, 2021
@tchaton tchaton self-assigned this Jul 14, 2021
@tchaton tchaton added this to the 0.4 milestone Jul 14, 2021
@tchaton tchaton marked this pull request as ready for review July 14, 2021 16:37
docs/source/api/pointcloud.rst Outdated Show resolved Hide resolved
docs/source/reference/semantic_segmentation.rst Outdated Show resolved Hide resolved
flash/pointcloud/__init__.py Outdated Show resolved Hide resolved
flash_examples/pointcloud_segmentation.py Outdated Show resolved Hide resolved
@mergify mergify bot removed the has conflicts label Jul 14, 2021
Copy link
Collaborator

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, LGTM 😃

docs/source/api/pointcloud.rst Outdated Show resolved Hide resolved
@tchaton tchaton merged commit 9c42528 into master Jul 14, 2021
@tchaton tchaton deleted the point_clouds branch July 14, 2021 19:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants