Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Graph embedding and graph backbones #592

Merged
merged 205 commits into from
Nov 9, 2021

Conversation

PabloAMC
Copy link
Contributor

@PabloAMC PabloAMC commented Jul 14, 2021

What does this PR do?

Fixes #510
Fixes #511
Fixes #512
Fixes #513
Fixes #514

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

pablo and others added 30 commits July 12, 2021 22:51
Lacking Pipeline and it is possible that division in raw and processed folders might be needed.
I'm unsure how to adapt
Lacking Pipeline and it is possible that division in raw and processed folders might be needed.
I'm unsure how to adapt
The class BasicGraphDataset in graphClassification/data.py is probably unneded
@mergify mergify bot removed the has conflicts label Nov 9, 2021
@ethanwharris ethanwharris changed the title Graph embedding and graph backbones (task-a-thon) Graph embedding and graph backbones Nov 9, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

from flash.core.utilities.providers import _PYTORCH_GEOMETRIC

if _GRAPH_AVAILABLE:
from torch_geometric.nn.models import GAT, GCN, GIN, GraphSAGE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we automate this and get all their models ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's not possible to do cleanly at the moment as the models package also contains many other things that wouldn't work in the GraphClassifier

flash/graph/classification/model.py Outdated Show resolved Hide resolved
flash/graph/embedding/model.py Outdated Show resolved Hide resolved
flash/graph/embedding/model.py Show resolved Hide resolved
@mergify mergify bot added the has conflicts label Nov 9, 2021
@mergify mergify bot removed the has conflicts label Nov 9, 2021
@ethanwharris ethanwharris merged commit 00ef240 into Lightning-Universe:master Nov 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants