Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

[Feat] Add PointCloud ObjectDetection #600

Merged
merged 28 commits into from
Jul 16, 2021
Merged

[Feat] Add PointCloud ObjectDetection #600

merged 28 commits into from
Jul 16, 2021

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Jul 16, 2021

What does this PR do?

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@pep8speaks
Copy link

pep8speaks commented Jul 16, 2021

Hello @tchaton! Thanks for updating this PR.

Line 123:117: W504 line break after binary operator

Comment last updated at 2021-07-16 17:06:58 UTC

@tchaton tchaton marked this pull request as ready for review July 16, 2021 13:55
Copy link
Contributor

@SeanNaren SeanNaren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know much about pointclouds, but LGTM :)

Copy link
Collaborator

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😃

@codecov
Copy link

codecov bot commented Jul 16, 2021

Codecov Report

Merging #600 (b3813a4) into master (00fd908) will decrease coverage by 0.99%.
The diff coverage is 70.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #600      +/-   ##
==========================================
- Coverage   90.90%   89.91%   -1.00%     
==========================================
  Files         132      140       +8     
  Lines        7795     8199     +404     
==========================================
+ Hits         7086     7372     +286     
- Misses        709      827     +118     
Flag Coverage Δ
unittests 89.91% <70.87%> (-1.00%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/pointcloud/segmentation/open3d_ml/app.py 30.61% <0.00%> (-1.39%) ⬇️
flash/pointcloud/detection/open3d_ml/app.py 27.36% <27.36%> (ø)
flash/pointcloud/detection/datasets.py 62.50% <62.50%> (ø)
flash/pointcloud/detection/model.py 82.81% <82.81%> (ø)
...ash/pointcloud/detection/open3d_ml/data_sources.py 82.90% <82.90%> (ø)
flash/pointcloud/detection/data.py 83.33% <83.33%> (ø)
flash/pointcloud/detection/open3d_ml/backbones.py 86.27% <86.27%> (ø)
flash/core/data/data_source.py 95.34% <100.00%> (+0.06%) ⬆️
flash/core/data/states.py 100.00% <100.00%> (ø)
flash/core/model.py 86.41% <100.00%> (+0.16%) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00fd908...b3813a4. Read the comment docs.

tests/pointcloud/detection/test_data.py Outdated Show resolved Hide resolved
tests/pointcloud/detection/test_data.py Outdated Show resolved Hide resolved
@tchaton tchaton merged commit 5b853c2 into master Jul 16, 2021
@tchaton tchaton deleted the pointcloud_obj branch July 16, 2021 17:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants