Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Flash CLI and Flash Zero #611

Merged
merged 50 commits into from
Aug 4, 2021
Merged

Flash CLI and Flash Zero #611

merged 50 commits into from
Aug 4, 2021

Conversation

ethanwharris
Copy link
Collaborator

@ethanwharris ethanwharris commented Jul 23, 2021

What does this PR do?

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jul 23, 2021

Codecov Report

Merging #611 (543912c) into master (f9d3348) will increase coverage by 0.74%.
The diff coverage is 93.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #611      +/-   ##
==========================================
+ Coverage   89.87%   90.62%   +0.74%     
==========================================
  Files         155      173      +18     
  Lines        8654     9183     +529     
==========================================
+ Hits         7778     8322     +544     
+ Misses        876      861      -15     
Flag Coverage Δ
gpu ?
pytest ?
unittests 90.62% <93.58%> (+0.74%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/audio/classification/data.py 93.75% <ø> (ø)
flash/audio/speech_recognition/data.py 76.72% <ø> (+2.58%) ⬆️
flash/graph/classification/data.py 93.10% <ø> (+13.79%) ⬆️
flash/image/classification/model.py 76.92% <ø> (ø)
flash/image/style_transfer/model.py 94.28% <ø> (+8.57%) ⬆️
flash/pointcloud/detection/data.py 82.85% <ø> (ø)
flash/pointcloud/segmentation/data.py 78.94% <ø> (ø)
flash/pointcloud/segmentation/model.py 76.66% <0.00%> (ø)
flash/video/classification/model.py 86.41% <ø> (ø)
flash/image/embedding/model.py 68.96% <33.33%> (+0.54%) ⬆️
... and 57 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9d3348...543912c. Read the comment docs.

@ethanwharris ethanwharris changed the title [WIP] Flash CLI PoC [WIP] Flash CLI and Flash Zero Aug 3, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a beautiful work !

@tchaton tchaton marked this pull request as ready for review August 3, 2021 17:09
@ethanwharris ethanwharris changed the title [WIP] Flash CLI and Flash Zero Flash CLI and Flash Zero Aug 3, 2021
@ethanwharris ethanwharris added the enhancement New feature or request label Aug 3, 2021
@ethanwharris ethanwharris merged commit 8e42d39 into master Aug 4, 2021
@ethanwharris ethanwharris deleted the feature/flash_cli_ethan branch August 4, 2021 11:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants