Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Add backbones for image embedding model #63

Merged
merged 4 commits into from
Feb 3, 2021

Conversation

kaushikb11
Copy link
Contributor

What does this PR do?

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Feb 3, 2021

Codecov Report

Merging #63 (020a272) into master (2d0e6f8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #63   +/-   ##
=======================================
  Coverage   86.51%   86.52%           
=======================================
  Files          46       46           
  Lines        1372     1365    -7     
=======================================
- Hits         1187     1181    -6     
+ Misses        185      184    -1     
Flag Coverage Δ
unittests 86.52% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/vision/backbones.py 95.83% <ø> (ø)
flash/vision/classification/model.py 100.00% <100.00%> (ø)
flash/vision/embedding/image_embedder_model.py 76.92% <100.00%> (-0.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d0e6f8...a6489c4. Read the comment docs.

@Borda Borda enabled auto-merge (squash) February 3, 2021 08:14
@Borda Borda added the enhancement New feature or request label Feb 3, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@carmocca carmocca merged commit 2af457b into Lightning-Universe:master Feb 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants