Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Add in_chans arg to resnet #673

Merged
merged 4 commits into from
Aug 17, 2021
Merged

Add in_chans arg to resnet #673

merged 4 commits into from
Aug 17, 2021

Conversation

ethanwharris
Copy link
Collaborator

What does this PR do?

Adds in_chans argument to resnet for consistency with timm

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@ananyahjha93 ananyahjha93 enabled auto-merge (squash) August 17, 2021 19:28
@codecov
Copy link

codecov bot commented Aug 17, 2021

Codecov Report

Merging #673 (c7b5c2f) into master (e86bfd9) will not change coverage.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #673   +/-   ##
=======================================
  Coverage   90.25%   90.25%           
=======================================
  Files         188      188           
  Lines        9730     9730           
=======================================
  Hits         8782     8782           
  Misses        948      948           
Flag Coverage Δ
unittests 90.25% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/image/classification/backbones/resnet.py 90.85% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e86bfd9...c7b5c2f. Read the comment docs.

@ethanwharris ethanwharris merged commit 18c5322 into master Aug 17, 2021
@ethanwharris ethanwharris deleted the feature/resnet_in_chans branch August 17, 2021 19:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants