Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

add swav and simclr models to imageclassifier + backbone reorg #68

Merged
merged 12 commits into from
Feb 5, 2021

Conversation

teddykoker
Copy link
Contributor

@teddykoker teddykoker commented Feb 3, 2021

What does this PR do?

Lets you do:

ImageClassifier(backbone="swav-imagenet")
ImageClassifier(backbone="simclr-imagenet")

Also reorgs all the model backbone loading to be in the same place

@codecov
Copy link

codecov bot commented Feb 3, 2021

Codecov Report

Merging #68 (9e279a5) into master (aeb0063) will increase coverage by 0.11%.
The diff coverage is 92.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #68      +/-   ##
==========================================
+ Coverage   86.50%   86.61%   +0.11%     
==========================================
  Files          46       45       -1     
  Lines        1363     1367       +4     
==========================================
+ Hits         1179     1184       +5     
+ Misses        184      183       -1     
Flag Coverage Δ
unittests 86.61% <92.30%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/vision/backbones.py 90.90% <91.42%> (-4.93%) ⬇️
flash/vision/classification/model.py 100.00% <100.00%> (ø)
flash/vision/embedding/image_embedder_model.py 80.00% <100.00%> (+3.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aeb0063...f8c7c70. Read the comment docs.

@teddykoker teddykoker changed the title add swav and simclr models to imageclassifier add swav and simclr models to imageclassifier + backbone reorg Feb 4, 2021
flash/vision/backbones.py Outdated Show resolved Hide resolved
flash/vision/backbones.py Outdated Show resolved Hide resolved
flash/vision/backbones.py Outdated Show resolved Hide resolved
@teddykoker teddykoker enabled auto-merge (squash) February 5, 2021 00:33
@teddykoker teddykoker merged commit cffcbd9 into master Feb 5, 2021
@teddykoker teddykoker deleted the teddy/swav_imageclassification branch February 5, 2021 17:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants