Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Remove redundant num_features arg from Classification model #88

Merged
merged 3 commits into from
Feb 8, 2021

Conversation

kaushikb11
Copy link
Contributor

What does this PR do?

Remove num_features arg from Classification model

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@carmocca
Copy link
Contributor

carmocca commented Feb 8, 2021

Mind annotating the rest of types in that signature?

@codecov
Copy link

codecov bot commented Feb 8, 2021

Codecov Report

Merging #88 (659b138) into master (13acf78) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #88   +/-   ##
=======================================
  Coverage   86.63%   86.63%           
=======================================
  Files          45       45           
  Lines        1369     1369           
=======================================
  Hits         1186     1186           
  Misses        183      183           
Flag Coverage Δ
unittests 86.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/vision/classification/model.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13acf78...1030303. Read the comment docs.

@kaushikb11
Copy link
Contributor Author

Mind annotating the rest of types in that signature?

@carmocca Done, thanks!

@Borda Borda enabled auto-merge (squash) February 8, 2021 14:48
@Borda Borda added the enhancement New feature or request label Feb 8, 2021
@Borda Borda merged commit 841986a into Lightning-Universe:master Feb 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants