-
Notifications
You must be signed in to change notification settings - Fork 212
Rename postprocess -> output_transform #942
Conversation
Codecov Report
@@ Coverage Diff @@
## master #942 +/- ##
==========================================
- Coverage 88.31% 84.60% -3.71%
==========================================
Files 242 243 +1
Lines 13030 13049 +19
==========================================
- Hits 11507 11040 -467
- Misses 1523 2009 +486
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
return default_uncollate(batch) | ||
|
||
@staticmethod | ||
def save_data(data: Any, path: str) -> None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe in future PR. I would drop the save_data, save_sample
. I don't believe this was ever used.
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
What does this PR do?
Fixes #919
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃