Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Remove unused Output saving mechanism #948

Merged
merged 2 commits into from
Nov 8, 2021

Conversation

ethanwharris
Copy link
Collaborator

@ethanwharris ethanwharris commented Nov 8, 2021

What does this PR do?

Fixes #947

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Nov 8, 2021

Codecov Report

Merging #948 (e46b09b) into master (4a8615f) will increase coverage by 0.08%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #948      +/-   ##
==========================================
+ Coverage   88.32%   88.41%   +0.08%     
==========================================
  Files         243      243              
  Lines       13059    13025      -34     
==========================================
- Hits        11535    11516      -19     
+ Misses       1524     1509      -15     
Flag Coverage Δ
unittests 88.41% <50.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/core/data/data_pipeline.py 96.85% <ø> (+1.16%) ⬆️
flash/core/data/utils.py 95.16% <ø> (ø)
flash/core/data/io/output_transform.py 97.77% <50.00%> (+14.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a8615f...e46b09b. Read the comment docs.

@ethanwharris ethanwharris changed the title Remove Output saving mechanism Remove unused Output saving mechanism Nov 8, 2021
@ethanwharris ethanwharris merged commit 7634dde into master Nov 8, 2021
@ethanwharris ethanwharris deleted the refactor/remove_save_data branch November 8, 2021 21:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove OutputTransform.save_data
2 participants