Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Fix DDP image classification #969

Merged
merged 4 commits into from
Nov 15, 2021
Merged

Conversation

ethanwharris
Copy link
Collaborator

@ethanwharris ethanwharris commented Nov 15, 2021

What does this PR do?

Fixes #967

Confirmed working on Grid 😃

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Nov 15, 2021

Codecov Report

Merging #969 (b6be769) into master (ad07463) will increase coverage by 0.02%.
The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #969      +/-   ##
==========================================
+ Coverage   88.26%   88.28%   +0.02%     
==========================================
  Files         250      250              
  Lines       13159    13149      -10     
==========================================
- Hits        11615    11609       -6     
+ Misses       1544     1540       -4     
Flag Coverage Δ
unittests 88.28% <90.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/image/classification/adapters.py 83.64% <90.00%> (+1.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad07463...b6be769. Read the comment docs.

@ethanwharris ethanwharris added the bug / fix Something isn't working label Nov 15, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@ethanwharris ethanwharris enabled auto-merge (squash) November 15, 2021 12:58
@ethanwharris ethanwharris merged commit f3a93d3 into master Nov 15, 2021
@ethanwharris ethanwharris deleted the bugfix/ddp_image_classification branch November 15, 2021 13:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug / fix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image classification NoModule bug with multi-gpu
3 participants