Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Refactor image inputs and update to new input object #997

Merged
merged 31 commits into from
Nov 30, 2021

Conversation

ethanwharris
Copy link
Collaborator

@ethanwharris ethanwharris commented Nov 25, 2021

What does this PR do?

Part of #961

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

flash/core/data/io/input.py Outdated Show resolved Hide resolved
flash/core/data/io/input.py Outdated Show resolved Hide resolved
flash/core/data/io/input.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 29, 2021

Codecov Report

Merging #997 (cd66eb5) into master (ce18c08) will decrease coverage by 3.43%.
The diff coverage is 91.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #997      +/-   ##
==========================================
- Coverage   88.40%   84.96%   -3.44%     
==========================================
  Files         250      254       +4     
  Lines       13199    13498     +299     
==========================================
- Hits        11668    11469     -199     
- Misses       1531     2029     +498     
Flag Coverage Δ
unittests 84.96% <91.14%> (-3.44%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/image/classification/cli.py 84.61% <ø> (ø)
...ash/image/classification/integrations/baal/data.py 41.48% <0.00%> (ø)
flash/image/style_transfer/cli.py 100.00% <ø> (ø)
flash/text/classification/data.py 55.67% <25.00%> (-41.23%) ⬇️
flash/core/data/io/input_base.py 86.45% <28.57%> (-9.93%) ⬇️
flash/core/data/io/input.py 69.70% <50.00%> (-24.80%) ⬇️
flash/image/style_transfer/data.py 91.07% <83.33%> (+1.98%) ⬆️
flash/core/data/utilities/data_frame.py 83.87% <83.87%> (ø)
flash/image/face_detection/data.py 51.56% <84.61%> (+7.90%) ⬆️
flash/core/data/utilities/paths.py 90.90% <89.65%> (+50.55%) ⬆️
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce18c08...cd66eb5. Read the comment docs.

@ethanwharris ethanwharris changed the title [WIP] Refactor image inputs and update to new input object Refactor image inputs and update to new input object Nov 29, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Awesome work !

flash/core/data/utilities/data_frame.py Outdated Show resolved Hide resolved
flash/core/data/utilities/paths.py Outdated Show resolved Hide resolved
Co-authored-by: thomas chaton <thomas@grid.ai>
@ethanwharris ethanwharris enabled auto-merge (squash) November 30, 2021 19:20
@ethanwharris ethanwharris merged commit b8085f0 into master Nov 30, 2021
@ethanwharris ethanwharris deleted the feature/image_inputs branch November 30, 2021 19:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants