Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed broken link in PR template #1675

Merged

Conversation

olineumann
Copy link
Contributor

@olineumann olineumann commented Apr 30, 2020

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

What does this PR do?

CHANGELOG.md link in PR template pointed to Error 404 Page from GitHub. It could be confusing for new users who make their first PR.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@mergify mergify bot requested a review from a team April 30, 2020 11:04
@codecov
Copy link

codecov bot commented Apr 30, 2020

Codecov Report

Merging #1675 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1675   +/-   ##
======================================
  Coverage      88%     88%           
======================================
  Files          71      71           
  Lines        4175    4175           
======================================
  Hits         3692    3692           
  Misses        483     483           

@williamFalcon williamFalcon merged commit 53aa563 into Lightning-AI:master Apr 30, 2020
@Borda Borda added the docs Documentation related label Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants