Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use model ref for tear down #2360

Merged
merged 1 commit into from
Jun 25, 2020
Merged

use model ref for tear down #2360

merged 1 commit into from
Jun 25, 2020

Conversation

williamFalcon
Copy link
Contributor

Fixes #2333

@williamFalcon williamFalcon changed the title fix 2333 use model ref for tear down Jun 25, 2020
@mergify mergify bot requested a review from a team June 25, 2020 14:12
justusschock
justusschock approved these changes Jun 25, 2020
View reviewed changes
Copy link
Member

@justusschock justusschock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@williamFalcon is there a way to test this?

Otherwise this looks good to me :)

@mergify mergify bot requested a review from a team June 25, 2020 14:26
@williamFalcon
Copy link
Contributor Author

not sure... this was a bug though. the models shouldn't have been called directly in the first place haha.
but i think the whole testing thing needs to be sorted out in the upcoming refactors

@codecov
Copy link

codecov bot commented Jun 25, 2020

Codecov Report

Merging #2360 into master will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #2360   +/-   ##
======================================
  Coverage      88%     88%           
======================================
  Files          70      70           
  Lines        5542    5543    +1     
======================================
+ Hits         4877    4878    +1     
  Misses        665     665

@williamFalcon williamFalcon merged commit d221817 into master Jun 25, 2020
@Borda Borda deleted the tear branch June 25, 2020 21:21
@Borda Borda added bug Something isn't working feature Is an improvement or enhancement labels Jun 25, 2020
@youngerous
Copy link

youngerous commented Jul 6, 2020 •
edited
Loading

I checked issue #2333 and this code-update, but it shows the same error('LightningDataParallel' object has no attribute 'teardown').

I'll wait for upcoming bug fixes, and thank you for your effort :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justusschock justusschock justusschock approved these changes

Assignees
No one assigned
Labels
bug Something isn't working feature Is an improvement or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AttributeError: 'LightningDataParallel' object has no attribute 'teardown'
4 participants
@williamFalcon @youngerous @justusschock @Borda