Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added emb similarity #3349

Merged
merged 1 commit into from
Sep 4, 2020
Merged

added emb similarity #3349

merged 1 commit into from
Sep 4, 2020

Conversation

williamFalcon
Copy link
Contributor

No description provided.

@mergify mergify bot requested a review from a team September 4, 2020 12:59
@williamFalcon williamFalcon merged commit 227959b into master Sep 4, 2020
@Borda Borda deleted the sim branch September 4, 2020 17:20
Borda
Borda reviewed Sep 4, 2020
View reviewed changes
pytorch_lightning/metrics/functional/self_supervised.py
Comment on lines +46 to +49
if __name__ == '__main__':
a = torch.rand(3, 5)

print(embedding_similarity(a, 'cosine'))
Copy link
Member

@Borda Borda Sep 4, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's remove this... mind squash it to any of your refactor?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Borda I have removed it in PR #3358, that additionally adds a class based interface + tests for this new metric

@mergify mergify bot requested a review from a team September 4, 2020 17:21
@SkafteNicki SkafteNicki mentioned this pull request Sep 5, 2020
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda left review comments

@SkafteNicki SkafteNicki SkafteNicki left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@williamFalcon @Borda @SkafteNicki