Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed model checkpoint frequency #3852

Merged
merged 5 commits into from
Oct 5, 2020
Merged

fixed model checkpoint frequency #3852

merged 5 commits into from
Oct 5, 2020

Conversation

williamFalcon
Copy link
Contributor

@williamFalcon williamFalcon commented Oct 5, 2020

Fixes #1764
Closes #3838

@pep8speaks
Copy link

pep8speaks commented Oct 5, 2020

Hello @williamFalcon! Thanks for updating this PR.

Line 193:13: W503 line break before binary operator

Comment last updated at 2020-10-05 01:09:26 UTC

@mergify mergify bot requested a review from a team October 5, 2020 00:46
@codecov
Copy link

codecov bot commented Oct 5, 2020

Codecov Report

Merging #3852 into master will increase coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #3852    +/-   ##
=======================================
+ Coverage      83%     88%    +4%     
=======================================
  Files         117     117            
  Lines        9106    9155    +49     
=======================================
+ Hits         7575    8016   +441     
+ Misses       1531    1139   -392     

@williamFalcon williamFalcon merged commit d9656d1 into master Oct 5, 2020
awaelchli pushed a commit that referenced this pull request Oct 5, 2020
* fixed model checkpoint frequency

* fixed model checkpoint frequency

* fixed model checkpoint frequency

* fixed model checkpoint frequency

* merged
awaelchli pushed a commit that referenced this pull request Oct 5, 2020
* fixed model checkpoint frequency

* fixed model checkpoint frequency

* fixed model checkpoint frequency

* fixed model checkpoint frequency

* merged
@Borda Borda deleted the 1764 branch October 5, 2020 06:12
@Borda Borda added the bug Something isn't working label Oct 5, 2020
@Borda Borda added this to the 0.10.0 milestone Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected Behaviour with Model Checkpointing and val_check_interval
3 participants