Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #2792 (overfit with multiple val loaders) #3857

Merged
merged 1 commit into from
Oct 5, 2020
Merged

Fixes #2792 (overfit with multiple val loaders) #3857

merged 1 commit into from
Oct 5, 2020

Conversation

williamFalcon
Copy link
Contributor

@williamFalcon williamFalcon commented Oct 5, 2020 •
edited
Loading

Fixes #2792
Fixes #2325
Fixes #2532

@mergify mergify bot requested a review from a team October 5, 2020 01:49
@williamFalcon williamFalcon changed the title Fixes #2792 Fixes #2792 (overfit with multiple val loaders) Oct 5, 2020
@ydcjeff
Copy link
Contributor

ydcjeff commented Oct 5, 2020 •
edited
Loading

@williamFalcon As you said before, this would load the dataloader twice, right?

That issue can be solved by passing dataloader_idx=None in validation/test_step. Seems like a hack tho.

@williamFalcon
Copy link
Contributor Author

It loads train once then with this it loads it a second time. I don't think setting the index to 0 is good because your code can depedn on the index (ie: a GAN).

@ydcjeff
Copy link
Contributor

ydcjeff commented Oct 5, 2020

Btw, the issue fixed is
#2325
#2532

@williamFalcon williamFalcon merged commit d787208 into master Oct 5, 2020
@Borda Borda deleted the 2532 branch October 5, 2020 06:12
@Borda Borda added the bug Something isn't working label Oct 5, 2020
@Borda Borda added this to the 0.10.0 milestone Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
pl:0.10
3 participants
@williamFalcon @ydcjeff @Borda