Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Metric <-> Lightning Module integration tests #4008

Merged
merged 3 commits into from
Oct 9, 2020
Merged

Add Metric <-> Lightning Module integration tests #4008

merged 3 commits into from
Oct 9, 2020

Conversation

teddykoker
Copy link
Contributor

@teddykoker teddykoker commented Oct 8, 2020 •
edited
Loading

Test Lightning integration with metrics

@mergify mergify bot requested a review from a team October 8, 2020 21:22
@teddykoker teddykoker requested review from ananyahjha93, awaelchli, Borda and justusschock and removed request for a team October 8, 2020 21:23
@mergify mergify bot requested a review from a team October 8, 2020 21:23
@pep8speaks
Copy link

pep8speaks commented Oct 8, 2020 •
edited
Loading

Hello @teddykoker! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-10-09 01:27:55 UTC

@codecov
Copy link

codecov bot commented Oct 8, 2020 •
edited
Loading

Codecov Report

Merging #4008 into master will increase coverage by 2%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #4008    +/-   ##
=======================================
+ Coverage      87%     89%    +2%     
=======================================
  Files         212     212            
  Lines       15499   15562    +63     
=======================================
+ Hits        13519   13873   +354     
+ Misses       1980    1689   -291

@Borda Borda added feature Is an improvement or enhancement Metrics labels Oct 8, 2020
Borda
Borda reviewed Oct 8, 2020
View reviewed changes
tests/metrics/test_metric_lightning.py
return self.step(x)

def training_epoch_end(self, outs):
assert torch.allclose(self.sum, self.metric.compute())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now much close, lets spec tolerance, also why not exact?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default tolerance is 1e-8, i can parameterize if you want. Can't do exact bc of floating point

@mergify mergify bot requested a review from a team October 8, 2020 22:17
@mergify mergify bot requested a review from a team October 9, 2020 01:37
@williamFalcon williamFalcon merged commit 7db26a9 into master Oct 9, 2020
@Borda Borda deleted the metric_lightning_test branch October 9, 2020 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda left review comments

@ananyahjha93 ananyahjha93 ananyahjha93 left review comments

@awaelchli awaelchli Awaiting requested review from awaelchli

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

Assignees
No one assigned
Labels
feature Is an improvement or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@teddykoker @pep8speaks @Borda @ananyahjha93 @williamFalcon