Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update explained variance metric #4024

Merged
merged 6 commits into from
Oct 9, 2020

Conversation

SkafteNicki
Copy link
Member

What does this PR do?

Update to explained variance metric

  • Add checks for shape
  • Add checks for division by zero
  • Adds multioutput parameter for handling multioutput cases (same as sklearn)

Also add a bit of description to the new metric testing function

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@pep8speaks
Copy link

pep8speaks commented Oct 9, 2020

Hello @SkafteNicki! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-10-09 12:41:07 UTC

@mergify mergify bot requested a review from a team October 9, 2020 10:30
pytorch_lightning/metrics/regression/explained_variance.py Outdated Show resolved Hide resolved
pytorch_lightning/metrics/regression/explained_variance.py Outdated Show resolved Hide resolved
tests/metrics/utils.py Outdated Show resolved Hide resolved
@mergify mergify bot requested a review from a team October 9, 2020 12:03
@Borda Borda added this to the 1.0 milestone Oct 9, 2020
@williamFalcon williamFalcon merged commit 8a3c800 into Lightning-AI:master Oct 9, 2020
@SkafteNicki SkafteNicki deleted the metrics/update2 branch October 15, 2020 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants